manuzhang commented on a change in pull request #26664: [SPARK-30074][SQL] The
maxNumPostShufflePartitions config should obey reducePostShufflePartitions
enabled
URL: https://github.com/apache/spark/pull/26664#discussion_r352497152
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -36,7 +36,7 @@ import org.apache.spark.sql.internal.SQLConf
*/
case class EnsureRequirements(conf: SQLConf) extends Rule[SparkPlan] {
private def defaultNumPreShufflePartitions: Int =
- if (conf.adaptiveExecutionEnabled) {
+ if (conf.adaptiveExecutionEnabled &&
conf.reducePostShufflePartitionsEnabled) {
Review comment:
@xuanyuanking is there any UT verifying the number of shuffle partitions
dependent on values of these two configurations ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
