HeartSaVioR commented on issue #26740: [SPARK-30053][SQL] Add the ability for v2 datasource so specify a vacuum action on the table URL: https://github.com/apache/spark/pull/26740#issuecomment-560933648 Just 2 cents as I'm not an expert of SQL area as well as just a contributor: 1) I read through the JIRA issue and see VACUUM is being supported for some systems. But do you have any custom data source which requires this, and if you have one could you please elaborate the plan? Without actual use case I'm not sure it's being accepted. 2) Looks like there're some Scala style issues. Could you please read through this doc https://github.com/databricks/scala-style-guide which is applied to Apache Spark repo as well? There're not only the lint error but also indentation issue which linter doesn't catch. 3) There're some spots which are modified for testing but they seem weird and shouldn't do it only for testing. I'll also leave comments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
