HeartSaVioR commented on a change in pull request #26740: [SPARK-30053][SQL]
Add the ability for v2 datasource so specify a vacuum action on the table
URL: https://github.com/apache/spark/pull/26740#discussion_r352923244
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -163,6 +164,12 @@ class InMemoryTable(
override def deleteWhere(filters: Array[Filter]): Unit =
dataMap.synchronized {
dataMap --= InMemoryTable.filtersToKeys(dataMap.keys, partFieldNames,
filters)
}
+
+ var vacuumed = false
Review comment:
Even though InMemoryTable is located in test, I'm not sure it can be
accepted. It's really a thing which is only added for UT and without
considering UT it's really odd as it's one-time flipping. It doesn't
represented the status as InMemoryTable itself doesn't need vacuum. You may
want to create another simple connector and leverage it for UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
