Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4421#issuecomment-73623236
Reynold,
It is similar, but I think the distinction here is that toDataFrame
appears to require that old names (and a schema) exist. Or, at least
that's what DataFrameImpl.scala suggests:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala,
line 93.
I think there's a benefit for a quick way to get a DataFrame from a
"plain" RDD. If we don't want to do @davies applyNames idea, then maybe we
can change the behavior of toDataFrame.
Cheers,
Dan
On Mon, Feb 9, 2015 at 4:33 PM, Reynold Xin <notificati...@github.com>
wrote:
> In particular, I'm talking about
>
https://github.com/apache/spark/blob/68b25cf695e0fce9e465288d5a053e540a3fccb4/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala#L105
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/4421#issuecomment-73621532>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
