cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date
and Timestamp type +/- null should be null as Postgres
URL: https://github.com/apache/spark/pull/26412#discussion_r352998689
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -246,6 +247,68 @@ class Analyzer(
CleanupAliases)
)
+ /**
+ * For [[UnresolvedAdd]]:
+ * 1. If one side is timestamp/date/string and the other side is interval,
turns it to
Review comment:
it's better to reduce the coupling between analyzer rule and type coercion
rule. I think here we should turn into `TimeAdd` if one side is interval, and
type coercion rule will cast date/string to timestamp for `TimeAdd`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
