cloud-fan commented on a change in pull request #26736: [SPARK-30098][SQL] Use 
default datasource as provider for CREATE TABLE syntax
URL: https://github.com/apache/spark/pull/26736#discussion_r353173922
 
 

 ##########
 File path: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -352,6 +358,15 @@ tableProvider
     : USING multipartIdentifier
     ;
 
+createTableClauses
 
 Review comment:
   how about
   ```
   createTableClause
     : (OPTIONS options=tablePropertyList) | ...
     ;
   ```
   Then we can reuse it in more places
   ```
   createTableHeader ... createTableClause*                              
#createTable
   createTableHeader ... (createTableClause | rowFormat | createFileFormat | 
...)* . #createHiveTable
   replaceTableHeader ... createTableClause*
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to