cloud-fan commented on a change in pull request #26656: [SPARK-27986][SQL]
Support ANSI SQL filter clause for aggregate expression
URL: https://github.com/apache/spark/pull/26656#discussion_r353186171
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
##########
@@ -119,18 +125,24 @@ case class AggregateExpression(
normalizedAggFunc.canonicalized.asInstanceOf[AggregateFunction],
mode,
isDistinct,
+ filter,
ExprId(0))
}
- override def children: Seq[Expression] = aggregateFunction :: Nil
+ override def children: Seq[Expression] = filter match {
+ case Some(expr) => aggregateFunction :: expr :: Nil
+ case _ => aggregateFunction :: Nil
+ }
+
override def dataType: DataType = aggregateFunction.dataType
override def foldable: Boolean = false
override def nullable: Boolean = aggregateFunction.nullable
@transient
override lazy val references: AttributeSet = {
mode match {
- case Partial | Complete => aggregateFunction.references
+ case Partial | Complete =>
+ aggregateFunction.references ++
filter.map(_.references).getOrElse(AttributeSet.empty)
Review comment:
nit: `++ filterAttributes`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
