cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date
and Timestamp type +/- null should be null as Postgres
URL: https://github.com/apache/spark/pull/26412#discussion_r353267201
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
##########
@@ -56,8 +56,10 @@ trait AnalysisTest extends PlanTest {
expectedPlan: LogicalPlan,
caseSensitive: Boolean = true): Unit = {
val analyzer = getAnalyzer(caseSensitive)
- val actualPlan = analyzer.executeAndCheck(inputPlan, new
QueryPlanningTracker)
- comparePlans(actualPlan, expectedPlan)
+ val tracker = new QueryPlanningTracker
+ val actualPlan = analyzer.executeAndCheck(inputPlan, tracker)
+ val actualExpectedPlan = analyzer.executeAndCheck(expectedPlan, tracker)
Review comment:
do we still need this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
