BryanCutler commented on issue #26496: [WIP][SPARK-29748][PYTHON][SQL] Remove Row field sorting in PySpark URL: https://github.com/apache/spark/pull/26496#issuecomment-561349805 Ok, I changed to @HyukjinKwon suggestion of using the env var to control sorting only, and also creation of the `__from_dict__` flag. I also change to error for Python < 3.6 to generate a warning and fallback to sorting fields and removed the option for using an OrderedDict. I think this is the most gentle approach to introducing new behavior (of not sorting) and still allowing users to create legacy Rows that are sorted, if needed. It will also be a fairly clean removal when Python < 3.6 is deprecated. I did have to set the env var by default for tests, but I introduced a new tests that makes an unsorted Row. Let me know if there is any issue with the current implementation, and I will add to the migration guide as soon as I can.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
