HyukjinKwon commented on a change in pull request #26496:
[WIP][SPARK-29748][PYTHON][SQL] Remove Row field sorting in PySpark
URL: https://github.com/apache/spark/pull/26496#discussion_r353494396
##########
File path: python/pyspark/sql/tests/test_types.py
##########
@@ -968,6 +968,19 @@ def __init__(self, **kwargs):
with self.assertRaises(exp, msg=msg):
_make_type_verifier(data_type, nullable=False)(obj)
+ @unittest.skipIf(sys.version_info[:2] < (3, 6), "Create Row without
sorting fields")
+ def test_Row_without_field_sorting(self):
Review comment:
no big deal but can we `test_Row_without_field_sorting` ->
`test_row_without_field_sorting`? Strictly it follows pep8 I guess (and I
personally don't like such names in the current codebase ... )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
