HeartSaVioR commented on issue #26502: [SPARK-29876][SS] Delete/archive file 
source completed files in separate thread
URL: https://github.com/apache/spark/pull/26502#issuecomment-561433573
 
 
   > Do the tests need any adjustment given that the cleaning is asynchronous 
now? (Maybe to disable the cleaning thread.)
   
   How about modifying `clean` to call `cleanTask` synchronously if it's being 
called from UT? (Would checking `IS_TESTING` in SparkConf work like what we do 
with FsHistoryProvider?) Given we have some UTs which don't directly call 
cleaner.clean, we still have to run cleanup in UTs.
   
   Alternatively we can check the files with `eventually` but it would add some 
latencies on verification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to