Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24388465
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -23,10 +23,16 @@ package org.apache.spark
private[spark] trait ExecutorAllocationClient {
/**
+ * Express a preference to the cluster manager for a given total number
of executors. This can
+ * result in canceling pending requests or filing additional requests.
+ */
+ private[spark] def requestTotalExecutors(numExecutors: Int): Boolean
+
+ /**
* Request an additional number of executors from the cluster manager.
- * Return whether the request is acknowledged by the cluster manager.
+ * This is currently only supported in YARN mode. Return whether the
request is received.
--- End diff --
If we want to add in the javadocs that it's only supported in YARN mode, we
should do it for all the methods here or just move this to the class javadocs.
I prefer the latter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
