dongjoon-hyun commented on a change in pull request #26758:
[SPARK-30124][MLLIB] unnecessary persist in PythonMLLibAPI.scala
URL: https://github.com/apache/spark/pull/26758#discussion_r353897726
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala
##########
@@ -408,7 +408,7 @@ private[python] class PythonMLLibAPI extends Serializable {
if (seed != null) gmmAlg.setSeed(seed)
try {
- new
GaussianMixtureModelWrapper(gmmAlg.run(data.rdd.persist(StorageLevel.MEMORY_AND_DISK)))
+ new GaussianMixtureModelWrapper(gmmAlg.run(data.rdd))
Review comment:
For me, this looks not harmful for the performance. Also, this PR seems to
break the symmetric structure of `try` and `finally`. If this has no effective
good, I'd like to recommend to avoid this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
