srowen commented on a change in pull request #26758: [SPARK-30124][MLLIB]
unnecessary persist in PythonMLLibAPI.scala
URL: https://github.com/apache/spark/pull/26758#discussion_r353904796
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala
##########
@@ -408,7 +408,7 @@ private[python] class PythonMLLibAPI extends Serializable {
if (seed != null) gmmAlg.setSeed(seed)
try {
- new
GaussianMixtureModelWrapper(gmmAlg.run(data.rdd.persist(StorageLevel.MEMORY_AND_DISK)))
+ new GaussianMixtureModelWrapper(gmmAlg.run(data.rdd))
Review comment:
I think the point is that the implementation also caches a small
transformation of it, so this one is kind of pointless. But yes, then the
unpersist() should be removed below.
I'm OK with it but we could fix some issues in GaussianMixture while we're
here. It never unpersists the data it caches internally, when it should do so.
It should also arguably respect whether the given RDD is already cached, but
maybe we skip that here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
