Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4446#discussion_r24390346
--- Diff: python/pyspark/sql.py ---
@@ -1889,9 +1931,57 @@ def insertInto(self, tableName, overwrite=False):
"""
self._jdf.insertInto(tableName, overwrite)
- def saveAsTable(self, tableName):
- """Creates a new table with the contents of this DataFrame."""
- self._jdf.saveAsTable(tableName)
+ def saveAsTable(self, tableName, dataSourceName=None, mode="append",
**options):
+ """Creates a new table with the contents of this DataFrame based
on the given data source
--- End diff --
btw for javadoc/python doc, the first sentence should be very short, e.g.
```python
"""Save the content of the DataFrame as a table in the catalog.
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
