yaooqinn commented on issue #26412: [SPARK-29774][SQL] Date and Timestamp type +/- null should be null as Postgres URL: https://github.com/apache/spark/pull/26412#issuecomment-561988016 > It seems like `UnresolvedBinaryExpression` brings some troubles and may add maintenance overhead. > > How about this: > > 1. We still create `Add` in the parser > 2. type coercion rules only deal with the normal Add operation, e.g. int + int, interval + interval. > 3. the new rule `ResolveBinaryArithmetic` finds the unresolved `Add`, and turn them into `DateAdd`, etc. depending on the data types. Simply replace the `UnresolvedXX` and change them back to the old ones
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
