srowen commented on a change in pull request #26769: [SPARK-30011][SQL] Inline
2.12 "AsIfIntegral" classes, not present in 2.13
URL: https://github.com/apache/spark/pull/26769#discussion_r354579360
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -622,6 +623,9 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
override def fromInt(x: Int): Decimal = new Decimal().set(x)
override def compare(x: Decimal, y: Decimal): Int = x.compare(y)
+ // Added from Scala 2.13; don't override to work in 2.12
+ // TODO revisit once Scala 2.12 support is dropped
Review comment:
Do you mean it shouldn't be a TODO, or should be recorded differently? I
just want to leave something in place so when one day I search for "Scala 2.12"
because we're cutting out the 2.12-specific stuff, I find this one :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
