Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4405#discussion_r24394308
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -145,7 +147,7 @@ object SparkSubmit {
}
// In all other modes, just run the main class as prepared
} else {
- runMain(childArgs, childClasspath, sysProps, childMainClass)
+ runMain(childArgs, childClasspath, sysProps, childMainClass, args)
--- End diff --
Could we avoid having to pass `SparkSubmitArguments` to `runMain` and
instead just deal with the `doAs` block out here? You only need it do it for
this lower case. In this script there is a actually a fairly good separation of
concerns here that the interface to `runMain` occurs strictly downstream from
the somewhat complicated logic in `SparkSubmitArguments`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
