HeartSaVioR commented on a change in pull request #26768:
[SPARK-30141][SQL][TESTS] Fix QueryTest.checkAnswer usage
URL: https://github.com/apache/spark/pull/26768#discussion_r354651023
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -2030,7 +2030,10 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession {
def verifyCallCount(df: DataFrame, expectedResult: Row, expectedCount:
Int): Unit = {
countAcc.setValue(0)
QueryTest.checkAnswer(
- df, Seq(expectedResult), checkToRDD = false /* avoid duplicate exec
*/)
+ df, Seq(expectedResult), checkToRDD = false /* avoid duplicate exec
*/) match {
Review comment:
Otherwise, maybe simply call checkAnswer (without QueryTest) - other places
in this suite already called like this. Same applies for other suites as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
