AngersZhuuuu commented on a change in pull request #26594:
[SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit
jdk8/jdk11
URL: https://github.com/apache/spark/pull/26594#discussion_r354668508
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -136,9 +137,48 @@ class KafkaTestUtils(
kdcConf.setProperty(MiniKdc.DEBUG, "true")
kdc = new MiniKdc(kdcConf, kdcDir)
kdc.start()
+ // TODO https://issues.apache.org/jira/browse/SPARK-30037
+ // Need to build spark's own MiniKDC and customize krb5.conf like Kafka
+ rewriteKrb5Conf()
kdcReady = true
}
+ /**
+ * In this method we rewrite krb5.conf to make kdc and client use the same
enctypes
+ */
+ private def rewriteKrb5Conf(): Unit = {
+ val krb5Conf = Source.fromFile(kdc.getKrb5conf, "UTF-8").getLines()
+ var rewritten = false
+ val addedConfig =
+ addedKrb5Config("default_tkt_enctypes", "aes128-cts-hmac-sha1-96") +
+ addedKrb5Config("default_tgs_enctypes", "aes128-cts-hmac-sha1-96")
+ val rewriteKrb5Conf = krb5Conf.map(s =>
+ if (s.contains("libdefaults")) {
+ rewritten = true
+ s + addedConfig
+ } else {
+ s
+ }).filter(!_.trim.startsWith("#")).mkString(System.lineSeparator())
+
+ val krb5confStr = if (!rewritten) {
+ "[libdefaults]" + addedConfig + System.lineSeparator() +
+ System.lineSeparator() + rewriteKrb5Conf
+ } else {
+ rewriteKrb5Conf
+ }
+
+ kdc.getKrb5conf.delete()
+ val writer = new PrintWriter(kdc.getKrb5conf)
+ // scalastyle:off println
+ writer.println(krb5confStr)
+ // scalastyle:on println
+ writer.close()
Review comment:
> Shall we use `Files.write(content, file, StandardCharsets.UTF_8)` instead
of `println`?
Done thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
