cloud-fan commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r354671403
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -618,19 +618,41 @@ object FunctionRegistry {
}
throw new AnalysisException(invalidArgumentsMsg)
}
- Try(f.newInstance(expressions : _*).asInstanceOf[Expression]) match {
- case Success(e) => e
- case Failure(e) =>
- // the exception is an invocation exception. To get a meaningful
message, we need the
- // cause.
- throw new AnalysisException(e.getCause.getMessage)
+ try {
+ f.newInstance(expressions : _*).asInstanceOf[Expression]
+ } catch {
+ // the exception is an invocation exception. To get a meaningful
message, we need the
+ // cause.
+ case e: Exception => throw new
AnalysisException(e.getCause.getMessage)
}
}
}
(name, (expressionInfo[T](name), builder))
}
+ private def expressionWithAlias[T <: Expression](name: String)
+ (implicit tag: ClassTag[T]): (String, (ExpressionInfo, FunctionBuilder))
= {
+ val constructors = tag.runtimeClass.getConstructors
+ .filter(_.getParameterTypes.head == classOf[String])
+ assert(constructors.length == 1)
+ val builder = (expressions: Seq[Expression]) => {
+ val params = classOf[String] +:
Seq.fill(expressions.size)(classOf[Expression])
+ val f = constructors.find(_.getParameterTypes.toSeq == params).getOrElse
{
Review comment:
here we not only check the # of arguments, but also argument types. Shall we
only check the # of arguments and leave the type check to the `newInstance`
call?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
