cloud-fan commented on a change in pull request #26684: [SPARK-30001][SQL]
ResolveRelations should handle both V1 and V2 tables.
URL: https://github.com/apache/spark/pull/26684#discussion_r354672146
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -665,21 +666,29 @@ class Analyzer(
}
/**
- * Resolve relations to temp views. This is not an actual rule, and is only
called by
- * [[ResolveTables]].
+ * Resolve relations to temp views. This is not an actual rule, and is
called by
+ * [[ResolveTables]] and [[ResolveRelations]].
*/
object ResolveTempViews extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp {
- case u @ UnresolvedRelation(Seq(part1)) =>
- v1SessionCatalog.lookupTempView(part1).getOrElse(u)
- case u @ UnresolvedRelation(Seq(part1, part2)) =>
- v1SessionCatalog.lookupGlobalTempView(part1, part2).getOrElse(u)
+ case u @ UnresolvedRelation(ident) =>
+ lookupTempOrGlobalTempView(ident).getOrElse(u)
+ case i @ InsertIntoStatement(UnresolvedRelation(ident), _, _, _, _) =>
+ lookupTempOrGlobalTempView(ident)
+ .map(view => i.copy(table = view))
+ .getOrElse(i)
}
+
+ def lookupTempOrGlobalTempView(identifier: Seq[String]):
Option[LogicalPlan] =
Review comment:
nit: I'd just call it `lookupTempView`, global temp view is also one kind of
temp view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
