07ARB commented on a change in pull request #26773:
[SPARK-30126][CORE]sparkContext.addFile fails when file path contains…
URL: https://github.com/apache/spark/pull/26773#discussion_r354800304
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1538,7 +1538,7 @@ class SparkContext(config: SparkConf) extends Logging {
val scheme = new URI(schemeCorrectedPath).getScheme
if (!Array("http", "https", "ftp").contains(scheme)) {
val fs = hadoopPath.getFileSystem(hadoopConfiguration)
- val isDir = fs.getFileStatus(hadoopPath).isDirectory
+ val isDir = fs.getFileStatus(new Path(path)).isDirectory
Review comment:
Yes, I have read the hadoop FileSystem document:
(https://hadoop.apache.org/docs/current/api/org/apache/hadoop/fs/FileSystem.html#getFileStatus-org.apache.hadoop.fs.Path-)
In this document they have not mention any limitation
```
public abstract FileStatus getFileStatus(Path f)
throws IOException
```
As per my knowledge this `(new File(path).getCanonicalFile.toURI)` will
convert **space** to **%20** in path which is causing the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
