cloud-fan commented on a change in pull request #26775: [SPARK-30018][SQL]
Support ALTER DATABASE SET OWNER syntax
URL: https://github.com/apache/spark/pull/26775#discussion_r354838697
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -94,11 +97,18 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
s"because view support in catalog has not been implemented yet")
case AlterNamespaceSetPropertiesStatement(NonSessionCatalog(catalog,
nameParts), properties) =>
- AlterNamespaceSetProperties(catalog.asNamespaceCatalog, nameParts,
properties)
+ val availableProps = properties -- RESERVED_PROPERTIES.asScala
Review comment:
OK so we can't follow Hive here. It seems wrong to me to change location and
owner with SET TBLPROPERTIES or SET DBPROPERTIES, but comment should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
