Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4412#discussion_r24399179
  
    --- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
    @@ -50,6 +50,15 @@ private[spark] class HttpFileServer(
     
       def stop() {
         httpServer.stop()
    +    
    +    // If we only stop sc, but the driver process still run as a services 
then we need to delete 
    +    // the tmp dir, if not, it will create too many tmp dirs
    +    try {
    +      Utils.deleteRecursively(baseDir)
    +    } catch {
    +      case e: Exception =>
    +        logWarning("Exception while deleting Spark temp dir: " + 
baseDir.getAbsolutePath, e)
    --- End diff --
    
    Nit: consider interpolation here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to