HeartSaVioR commented on a change in pull request #26788:
[WIP][SPARK-30159][SQL][TESTS] Fix the method calls of `QueryTest.checkAnswer`
URL: https://github.com/apache/spark/pull/26788#discussion_r355154327
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala
##########
@@ -352,15 +352,15 @@ class BinaryFileFormatSuite extends QueryTest with
SharedSparkSession {
.select(CONTENT)
}
val expected = Seq(Row(content))
- QueryTest.checkAnswer(readContent(), expected)
+ checkAnswer(readContent, expected)
Review comment:
nit: maybe either removing `()` from function or roll back the change of
removing `()`? It's not just retrieving the value, adding `()` seems to be
semantically correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
