srowen commented on a change in pull request #26788:
[WIP][SPARK-30159][SQL][TESTS] Fix the method calls of `QueryTest.checkAnswer`
URL: https://github.com/apache/spark/pull/26788#discussion_r355192347
##########
File path:
sql/core/src/test/java/test/org/apache/spark/sql/JavaSaveLoadSuite.java
##########
@@ -43,7 +43,7 @@
Dataset<Row> df;
private static void checkAnswer(Dataset<Row> actual, List<Row> expected) {
- String errorMessage = QueryTest$.MODULE$.checkAnswer(actual, expected);
+ String errorMessage =
QueryTest$.MODULE$.getErrorMessageInCheckAnswer(actual, expected);
if (errorMessage != null) {
Review comment:
This construction seems kinda pointless then. Why not just let checkAnswer
fail with an assertion, rather than have a separate method that only returns
the error and have tests manually check if there's an error string and fail it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
