amanomer commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when bool_and() and bool_or() is called using alias
URL: https://github.com/apache/spark/pull/26712#discussion_r355239025
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -590,12 +590,12 @@ object FunctionRegistry {
val builder = (expressions: Seq[Expression]) => {
if (varargCtor.isDefined) {
// If there is an apply method that accepts Seq[Expression], use that
one.
- Try(varargCtor.get.newInstance(expressions).asInstanceOf[Expression])
match {
- case Success(e) => e
- case Failure(e) =>
- // the exception is an invocation exception. To get a meaningful
message, we need the
- // cause.
- throw new AnalysisException(e.getCause.getMessage)
Review comment:
I think there are similar try-catch block format on other files too, which
can be reformatted like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
