tgravescs commented on a change in pull request #26586: [SPARK-29950][k8s]
Blacklist deleted executors in K8S with dynamic allocation.
URL: https://github.com/apache/spark/pull/26586#discussion_r355734371
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##########
@@ -141,10 +148,17 @@ private[spark] class ExecutorPodsAllocator(
}
.map { case (id, _) => id }
+ // Make a local, non-volatile copy of the reference since it's used
multiple times. This
+ // is the only method that modifies the list, so this is safe.
+ var _excessExecutors = excessExecutors
+
if (snapshots.nonEmpty) {
logDebug(s"Pod allocation status: $currentRunningCount running, " +
s"${currentPendingExecutors.size} pending, " +
s"${newlyCreatedExecutors.size} unacknowledged.")
+
+ val existingExecs = snapshots.last.executorPods.keySet
Review comment:
I think you could use lastSnapshot instead of snapshots.last
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
