Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4066#discussion_r24440434
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
    @@ -148,6 +148,20 @@ case object TaskKilled extends TaskFailedReason {
     
     /**
      * :: DeveloperApi ::
    + * Task requested the driver to commit, but was denied.
    + */
    +@DeveloperApi
    +case class TaskCommitDenied(
    +    jobID: Int,
    +    splitID: Int,
    --- End diff --
    
    I actually think that partitionID might be clearer here.  If you look at 
how these values are set, they come from the `splitId` that's used to configure 
`SparkHadoopWriter`, which is a partition id in the range `0 to numPartitions`, 
whereas a taskId might be confused for a globally unique task identifier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to