srowen commented on a change in pull request #26826:
[SPARK-30195][SQL][CORE][ML] Change some function, import definitions to work
with stricter compiler in Scala 2.13
URL: https://github.com/apache/spark/pull/26826#discussion_r355826593
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
##########
@@ -201,7 +201,7 @@ class BlockManagerMaster(
Option[BlockStatus],
Iterable[Option[BlockStatus]]]]
val blockStatus = timeout.awaitResult(
- Future.sequence[Option[BlockStatus], Iterable](futures)(cbf,
ThreadUtils.sameThread))
+ Future.sequence(futures)(cbf, ThreadUtils.sameThread))
Review comment:
immutable.Iterable seems to have been the right-er choice for CanBuildFrom
here; doesn't require overriding the generic types. It didn't compile otherwise
in 2.13.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
