dongjoon-hyun commented on a change in pull request #26824:
[SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory
URL: https://github.com/apache/spark/pull/26824#discussion_r355832240
##########
File path: python/requirements.txt
##########
@@ -0,0 +1,4 @@
+numpy==1.16.4
+scipy==1.2.2
Review comment:
For `scipy`, I overlooked the real test cases. Yes. It was just a test
dependency like the following.
```
Skipped tests in pyspark.mllib.tests.test_linalg with python:
test_classification (pyspark.mllib.tests.test_linalg.SciPyTests) ...
skipped 'SciPy not installed'
test_clustering (pyspark.mllib.tests.test_linalg.SciPyTests) ... skipped
'SciPy not installed'
test_convert_to_vector (pyspark.mllib.tests.test_linalg.SciPyTests) ...
skipped 'SciPy not installed'
test_dot (pyspark.mllib.tests.test_linalg.SciPyTests) ... skipped 'SciPy
not installed'
test_regression (pyspark.mllib.tests.test_linalg.SciPyTests) ... skipped
'SciPy not installed'
test_serialize (pyspark.mllib.tests.test_linalg.SciPyTests) ... skipped
'SciPy not installed'
test_squared_distance (pyspark.mllib.tests.test_linalg.SciPyTests) ...
skipped 'SciPy not installed'
Skipped tests in pyspark.tests.test_serializers with python:
test_serialize (pyspark.tests.test_serializers.SciPyTests) ... skipped
'SciPy not installed'
```
Since this is moved to `dev`, I'll update the PR description and keep this
for `dev` purpose~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
