imback82 commented on a change in pull request #26741: [SPARK-30104][SQL] Fix
catalog resolution for 'global_temp'
URL: https://github.com/apache/spark/pull/26741#discussion_r355841843
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -467,20 +470,20 @@ class ResolveSessionCatalog(
replace,
viewType)
- case ShowTablePropertiesStatement(SessionCatalog(_, tableName),
propertyKey) =>
+ case ShowTablePropertiesStatement(SessionCatalogAndTable(_, tableName),
propertyKey) =>
ShowTablePropertiesCommand(
tableName.asTableIdentifier,
propertyKey)
case ShowFunctionsStatement(userScope, systemScope, pattern, fun) =>
val (database, function) = fun match {
- case Some(CatalogAndIdentifierParts(catalog, functionName)) =>
+ case Some(CatalogObjectIdentifier(catalog, functionIdent)) =>
Review comment:
Does function identifiers need to handle global_temp, etc.? or just going
thru `CatalogObjectIdentifier` is enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
