Github user ryan-williams commented on a diff in the pull request:
https://github.com/apache/spark/pull/3525#discussion_r24446161
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -203,6 +203,28 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging {
getOption(key).map(_.toBoolean).getOrElse(defaultValue)
}
+ // Limit of bytes for total size of results (default is 1GB)
--- End diff --
I weighed two options:
1. have a method in `Utils` that takes a `SparkConf` as a parameter and
thinly wraps a method call on said `SparkConf`
1. make the aforementioned wrapper a method on `SparkConf` that delegates
to another method on `SparkConf`
..and felt like the latter was better/cleaner. My feeling was that a
kitchen-sink / generically-named `Utils` class that wraps methods for
`SparkConf` (and possibly other classes?) to maintain an illusion of simplicity
in the `SparkConf` API is not helping code clarity.
Of course, this is subjective and I'm open to putting it back in `Utils`,
lmk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
