cloud-fan commented on a change in pull request #26779: [SPARK-30150][SQL]ADD
FILE, ADD JAR, LIST FILE & LIST JAR Command do not accept quoted path
URL: https://github.com/apache/spark/pull/26779#discussion_r355993690
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -221,7 +221,7 @@ statement
multipartIdentifier partitionSpec?
#loadData
| TRUNCATE TABLE multipartIdentifier partitionSpec?
#truncateTable
| MSCK REPAIR TABLE multipartIdentifier
#repairTable
- | op=(ADD | LIST) identifier .*?
#manageResource
+ | op=(ADD | LIST) identifier (STRING | .*?)
#manageResource
Review comment:
yea, but isn't `(STRING | .*)?` more logical? or there are some perf
concerns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
