Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4511#discussion_r24453244
--- Diff:
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/KafkaStreamSuite.scala
---
@@ -53,8 +53,8 @@ abstract class KafkaStreamSuiteBase extends FunSuite with
Eventually with Loggin
private val zkConnectionTimeout = 6000
private val zkSessionTimeout = 6000
private var zookeeper: EmbeddedZookeeper = _
- private val brokerHost = "localhost"
- private var brokerPort = 9092
+ protected val brokerHost = "localhost"
+ protected var brokerPort = 9092
--- End diff --
Notice that in the previous PR i refactored to put brokerAddress behind the
ready flag? I had done this to make sure we dont accidentally use the port
value before the broker is ready. This is because the port number can change
depending on which port does the broker setup successfully bind to. If you
really need the port, then could you put this behind the ready flag as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
