srowen commented on a change in pull request #26842: [SPARK-29392][CORE][SQL]
More removal of 'foo Symbol syntax for Scala 2.13
URL: https://github.com/apache/spark/pull/26842#discussion_r356383276
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -1538,11 +1538,9 @@ class DatasetSuite extends QueryTest with
SharedSparkSession {
checkAnswer(df.sort("id"), expected)
checkAnswer(df.sort(col("id")), expected)
checkAnswer(df.sort($"id"), expected)
- checkAnswer(df.sort('id), expected)
Review comment:
Yes this one I removed because it's actually redundant. It is either exactly
the same as `.sort("id")` or `.sort("$id")` depending on which implicit kicks
in. That's already true in Scala 2.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
