HeartSaVioR commented on a change in pull request #26771: [SPARK-30143][SS] Add
a timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r356363756
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
##########
@@ -434,6 +434,30 @@ abstract class StreamExecution(
}
}
+ /**
+ * Interrupts the query execution thread and awaits its termination until the
Review comment:
> until the `spark.sql.streaming.stopTimeout`
That seems to be ended oddly. I'd rather reword as `until it exceeds the
timeout.`, and maybe optionally describe `Timeout can be set on
"spark.sql.streaming.stopTimeout".`. Given this method is not exposed by end
users, I'd assume we might not need to explicitly describe configuration in
scaladoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
