dongjoon-hyun commented on a change in pull request #26779: [SPARK-30150][SQL]
ADD FILE, ADD JAR, LIST FILE & LIST JAR Command do not accept quoted path
URL: https://github.com/apache/spark/pull/26779#discussion_r356402338
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -259,4 +259,22 @@ class SparkSqlParserSuite extends AnalysisTest {
parser.parsePlan("ALTER SCHEMA foo SET DBPROPERTIES ('x' = 'y')"))
assertEqual("DESC DATABASE foo", parser.parsePlan("DESC SCHEMA foo"))
}
+
+ test("manage resources") {
+ assertEqual("ADD FILE abc.txt", AddFileCommand("abc.txt"))
+ assertEqual("ADD FILE \'abc.txt\'", AddFileCommand("abc.txt"))
+ assertEqual("ADD FILE \"/path/to/abc.txt\"",
AddFileCommand("/path/to/abc.txt"))
+ assertEqual("LIST FILE abc.txt", ListFilesCommand("abc.txt".split("\\s+")))
Review comment:
Shall we use simply `Array("/path//abc.txt")` instead of
`"abc.txt".split("\\s+")`? (here and the below `LIST` test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
