HeartSaVioR edited a comment on issue #26821: [SPARK-20656][CORE]Support 
Incremental parsing of event logs in SHS
URL: https://github.com/apache/spark/pull/26821#issuecomment-564422644
 
 
   @shahidki31 
   No I didn't intend to persuade you to close this. I'd just wanted to make 
sure we get a clear picture of full implementation before dealing with each 
part, but it's OK for me if you'd like to deal with current solution as I think 
I can deal with extending the solution with snapshotting.
   
   I can take a look with current solution, but you still need to persuade at 
least one committer to push this forward.
   
   Btw, we'd be better to clarify the performance test in details. It should 
include at least...
   
   * size of event log file for initial load
   * elapsed time for initial load
   * count/size of events for addition (mostly about size)
   * elapsed time for loading additional events
   
   For me, your statement in PR description sounds to me as skipping (via read 
and drop) 2G takes around 2 secs which is still not ideal (as we know how to do 
it better), though I agree that's still a huge improvement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to