Github user ksakellis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4510#discussion_r24464381
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala 
---
    @@ -344,6 +346,20 @@ class ShuffleReadMetrics extends Serializable {
       private[spark] def decRemoteBytesRead(value: Long) = _remoteBytesRead -= 
value
     
       /**
    +   * Time the task spent (in milliseconds) reading local shuffle blocks 
(from the local disk).
    +   */
    +  private var _localReadTime: Long = _
    +  def localReadTime = _localReadTime
    +  private[spark] def incLocalReadTime(value: Long) = _localReadTime += 
value
    +
    +  /**
    +   * Shuffle data that was read from the local disk (as opposed to from a 
remote executor).
    +   */
    +  private var _localBytesRead: Long = _
    +  def localBytesRead = _localBytesRead
    +  private[spark] def incLocalBytesRead(value: Long) = _localBytesRead += 
value
    +
    +  /**
        * Number of blocks fetched in this shuffle by this task (remote or 
local)
        */
       def totalBlocksFetched = _remoteBlocksFetched + _localBlocksFetched
    --- End diff --
    
    To stay consistent, can you add def totalBytesRead = _remoteBytesRead + 
_localBytesRead



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to