MaxGekk commented on a change in pull request #26799: [SPARK-30170][SQL][MLLIB]
Eliminate compilation warnings: part 1
URL: https://github.com/apache/spark/pull/26799#discussion_r356657179
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/FloatType.scala
##########
@@ -78,8 +78,12 @@ case object FloatType extends FloatType {
}
trait FloatAsIfIntegral extends FloatIsConflicted with Integral[Float] {
- def quot(x: Float, y: Float): Float = (BigDecimal(x) quot
BigDecimal(y)).floatValue
- def rem(x: Float, y: Float): Float = (BigDecimal(x) remainder
BigDecimal(y)).floatValue
+ def quot(x: Float, y: Float): Float = {
Review comment:
> I am not sure why it's deprecated, or what the 'default conversion' issue
is.
The code was removed by
https://github.com/scala/scala/pull/6468/files#diff-a1c7fbbd4efafafc57671a3ac783aaeaL143-L149
due to troubles with Double/Float ranges.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
