cloud-fan commented on a change in pull request #26817: [SPARK-30192][SQL]
support column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r356422266
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2802,19 +2803,24 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
Option(ctx.partitionSpec).map(visitNonOptionalPartitionSpec))
}
+ override def visitColPosition(ctx: ColPositionContext): ColumnPosition = {
+ ctx.position.getType match {
+ case SqlBaseParser.FIRST => ColumnPosition.FIRST
+ case SqlBaseParser.AFTER =>
+
ColumnPosition.After(typedVisit[Seq[String]](ctx.multipartIdentifier).toArray)
+ }
+ }
+
/**
* Parse new column info from ADD COLUMN into a QualifiedColType.
*/
override def visitQualifiedColTypeWithPosition(
ctx: QualifiedColTypeWithPositionContext): QualifiedColType =
withOrigin(ctx) {
- if (ctx.colPosition != null) {
- operationNotAllowed("ALTER TABLE table ADD COLUMN ... FIRST | AFTER
otherCol", ctx)
- }
-
QualifiedColType(
typedVisit[Seq[String]](ctx.name),
typedVisit[DataType](ctx.dataType),
- Option(ctx.comment).map(string))
+ Option(ctx.comment).map(string),
+ Option(ctx.colPosition).map(typedVisit[ColumnPosition]))
Review comment:
They are the same. `typedVisit` would call `visitColPosition` under the hood
(via looking at the context). We use `typedVisit` a lot in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
