cloud-fan commented on a change in pull request #26853:
[SPARK-30104][SQL][FOLLOWUP] Replace CatalogObjectIdentifier with
CatalogAndIdentifier
URL: https://github.com/apache/spark/pull/26853#discussion_r356765123
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/LookupCatalogSuite.scala
##########
@@ -46,13 +49,16 @@ class LookupCatalogSuite extends SparkFunSuite with
LookupCatalog with Inside {
catalogs.getOrElse(name, throw new CatalogNotFoundException(s"$name not
found"))
})
when(manager.currentCatalog).thenReturn(sessionCatalog)
+ when(manager.v2SessionCatalog).thenReturn(sessionCatalog)
manager
}
- test("catalog object identifier") {
+ test("catalog and identifier") {
Seq(
("tbl", sessionCatalog, Seq.empty, "tbl"),
("db.tbl", sessionCatalog, Seq("db"), "tbl"),
+ (s"$globalTempDB.tbl", sessionCatalog, Seq(globalTempDB), "tbl"),
+ (s"$globalTempDB.ns1.ns2.tbl", catalogs(globalTempDB), Seq("ns1",
"ns2"), "tbl"),
Review comment:
no we can't. `global_temp` is kind of a reserved catalog that only contains
global temp views. If a user-registered catalog is also named `global_temp`, it
should be masked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
