zsxwing commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-564735539 @uncleGen This is a great improvement! Thanks for your contribution. I took a look quickly and found one major issue: this PR right now is keeping all `StreamingQuery` objects. It's better to use StreamingQueryListener to track query status instead. All of our other UI pages are using listeners to extract information. In addition, the UI should never use any objects that are only available in runtime, so that it's possible to re-create the UI in history server by replaying events. You can take a look at `org.apache.spark.status.AppStatusListener`, `org.apache.spark.streaming.ui.StreamingJobProgressListener` and `org.apache.spark.sql.execution.ui.SQLAppStatusListener`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
