srowen commented on issue #26831: [SPARK-30201][SQL] HiveOutputWriter 
standardOI should use ObjectInspectorCopyOption.DEFAULT
URL: https://github.com/apache/spark/pull/26831#issuecomment-565000171
 
 
   I can sort of buy this logic if it only affects Hive and basically doesn't 
make it work any _less_. But the round trip from non-UTF-8-bytes -> read as 
UTF-8 -> get bytes will definitely not give you back the same bytes in some 
cases. It won't parse in some cases either. This seems a bit fragile.
   
   The change is also broader than just affecting this case. It affects much 
more, potentially, about how everything is read. It'll be interesting to see 
how tests run, but this makes me a bit nervous.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to