Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4511#discussion_r24472396
--- Diff:
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/KafkaRDDSuite.scala
---
@@ -40,43 +41,70 @@ class KafkaRDDSuite extends KafkaStreamSuiteBase with
BeforeAndAfter {
tearDownKafka()
}
--- End diff --
True. But, ....
1 is a riskier change, that should be done later (not for this release),
dont want to introduce flakiness
2. is a greater refactoring, that is definitely not worth doing now. I am
not sure though nested testsuites are a good idea or not. Stickign all the
Kafka tests in a single testsuite is something that we can consider, there are
pros and cons.
For now at least we should reuse the kafka harness within the same
testsuite. I did that for the other Kafka testsuites. The bigger question we
can address in separate PRs meant for next release cycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
