viirya commented on a change in pull request #26854: [SPARK-30040][SQL] DROP
FUNCTION should do multi-catalog resolution
URL: https://github.com/apache/spark/pull/26854#discussion_r357321619
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -503,6 +503,19 @@ class ResolveSessionCatalog(
case None => (None, pattern)
}
ShowFunctionsCommand(database, function, userScope, systemScope)
+
+ case DropFunctionStatement(CatalogAndIdentifier(catalog, functionIdent),
ifExists, isTemp) =>
+ if (isSessionCatalog(catalog)) {
+ val (database, function) = functionIdent.asMultipartIdentifier match
{
+ case Seq (db, fn) => (Some(db), fn)
+ case Seq (fn) => (None, fn)
+ case _ =>
+ throw new AnalysisException (s"Unsupported function name
'${functionIdent.quoted}'")
+ }
+ DropFunctionCommand(database, function, ifExists, isTemp)
+ } else {
+ throw new AnalysisException ("DROP FUNCTION is only supported in v1
catalog")
Review comment:
ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
