HeartSaVioR commented on a change in pull request #26714: [SPARK-25100][CORE]
Fix no registering TaskCommitMessage bug
URL: https://github.com/apache/spark/pull/26714#discussion_r357388514
##########
File path:
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala
##########
@@ -358,6 +359,26 @@ class KryoSerializerSuite extends SparkFunSuite with
SharedSparkContext {
}
}
+ test("registration of TaskCommitMessage") {
+ val conf = new SparkConf(false)
+ conf.set(KRYO_REGISTRATION_REQUIRED, true)
+
+ val ser = new KryoSerializer(conf).newInstance()
+ // In HadoopMapReduceCommitProtocol#commitTask
+ val addedAbsPathFiles: mutable.Map[String, String] = mutable.Map()
+ addedAbsPathFiles.put("test1", "test1")
+ addedAbsPathFiles.put("test2", "test2")
+
+ val partitionPaths: mutable.Set[String] = mutable.Set()
+ partitionPaths.add("test3")
+
+ val taskCommitMessage1 = new TaskCommitMessage(addedAbsPathFiles.toMap ->
partitionPaths.toSet)
+ val taskCommitMessage2 = new TaskCommitMessage(Map.empty -> Set.empty)
+ Seq(taskCommitMessage1, taskCommitMessage2).foreach { taskCommitMessage =>
+ ser.serialize(taskCommitMessage)
Review comment:
I'd also deserialize and do equivalence verification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
