squito commented on a change in pull request #26682: [SPARK-29306][CORE] Stage
Level Sched: Executors need to track what ResourceProfile they are created with
URL: https://github.com/apache/spark/pull/26682#discussion_r357741290
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -52,6 +53,7 @@ private[spark] class ExecutorMonitor(
conf.get(DYN_ALLOCATION_SHUFFLE_TRACKING)
private val executors = new ConcurrentHashMap[String, Tracker]()
+ private val execResourceProfileCount = new mutable.HashMap[Int, Int]()
Review comment:
Its a bit surprising that this doesn't need to be a CHM, when `executors`
does (because its referenced from `ExecutorAllocationManager.schedule()`
method). I think it looks OK on a first pass just want to check you'd checked
this as well. I guess the key thing is that `timedOutExecutors()` doesn't
actually need to know anything about ResourceProfiles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
